Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkaninfo: Fix unreported extension formats #1098

Merged
merged 1 commit into from
Mar 27, 2025
Merged

vulkaninfo: Fix unreported extension formats #1098

merged 1 commit into from
Mar 27, 2025

Conversation

andy-poole-samsung
Copy link
Contributor

Changes the format support check to compare against the device extensions instead of the instance extensions.

@andy-poole-samsung
vulkaninfo: Fix unreported extension formats
d99dd90 
Changes the format support check to compare against the
device extensions instead of the instance extensions.
@ci-tester-lunarg
Copy link

Author andy-poole-samsung not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author andy-poole-samsung not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

charles-lunarg
charles-lunarg approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy COW. Thank you for finding and fixing! This bug has been here for literal years, possibly a decade. Its so old is predates the big vulkaninfo rewrite in 2019!

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 406519.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1661 running.

@andy-poole-samsung
Copy link
Contributor Author

Holy COW. Thank you for finding and fixing! This bug has been here for literal years, possibly a decade. Its so old is predates the big vulkaninfo rewrite in 2019!

No problem! One of my colleagues noticed it in our testing so we're glad to fix it 😃

@charles-lunarg
Copy link
Contributor

At first I thought it couldn't possibly be a real bug - often times I've found that the code was right, then became wrong on rewrite/refactor. Well, this one was very much wrong from way back when. Appreciate your colleague having some eagle eyes to spot this.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1661 passed.

@charles-lunarg charles-lunarg merged commit da7c7db into KhronosGroup:main Mar 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy-poole-samsung @ci-tester-lunarg @CLAassistant @charles-lunarg